Ticket #59 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Main menu: move 'Check for updates' item from File to Help menu

Reported by: masyura.sergey@… Owned by: maxence@…
Priority: high Milestone:
Component: UI > Main window Version: Nightly build
Severity: normal Keywords:
Cc: masyura.sergey@…, sclebo05@… Operating System: unspecified
Java version: unspecified

Description

Main menu: move 'Check for updates' item from File to Help menu.
It's very unusual to see that item there.
The better place for that is Help menu like this is done in firefox or ultraedit.
My proposal for updated Help menu is the next:
...
Make a donation


Check for updates


About muCommander

Attachments

muco-bug59.diff (1.5 kB) - added by sclebo05@… 2 years ago.
Move Check for Updates from File menu to Help menu
muco-bug59.2.diff (1.4 kB) - added by sclebo05@… 2 years ago.
Attachment 22 updated

Change History

Changed 2 years ago by masyura.sergey@…

  • cc masyura.sergey@… added

Changed 2 years ago by sclebo05@…

Move Check for Updates from File menu to Help menu

Changed 2 years ago by sclebo05@…

  • cc sclebo05@… added

Changed 2 years ago by masyura.sergey@…

Hi Joshua, why did you move "fileMenu.add(new JSeparator());" to Help menu related code, we should not do that. We just need to remove it from line 161.
Except this comment the patch looks fine. Do I need to perform some actions on this bug (move to resolved state, etc)?

Changed 2 years ago by sclebo05@…

  • attachments.isobsolete changed from 0 to 1

Changed 2 years ago by sclebo05@…

Attachment 22 updated

Changed 2 years ago by maxence@…

  • status changed from new to closed
  • resolution set to fixed

Sergey, Joshua, thanks a lot for resolving this issue! It makes more sense indeed to have 'Check for updates' in the Help menu, plus it frees up some space from the crowded File menu.

I just committed the fix (2nd patch) to the svn repository, the fix will be part of tomorrow's nightly build.

Thanks again!

Note: See TracTickets for help on using tickets.